Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add PREZ_VERSION environment variable to Dockerfile #216

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

edmondchuc
Copy link
Collaborator

I was hoping that the prez version is read from pyproject.toml but it is not being set when the container image is built via GH Actions for some reason.

This PR sets the PREZ_VERSION environment variable in the Dockerfile itself. The prez application will use this as the fallback version if it cannot read from pyproject.toml.

Copy link
Collaborator

@recalcitrantsupplant recalcitrantsupplant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested locally - have used same pattern in other images happy that this works

@edmondchuc edmondchuc merged commit 7a7f028 into main Apr 2, 2024
2 checks passed
@edmondchuc edmondchuc deleted the edmond/docker branch April 2, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants